-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cat-voices): vit ss endpoints generating #1302
base: mve3
Are you sure you want to change the base?
Conversation
✅ Test Report | |
✅ Test Report | |
@@ -1 +1 @@ | |||
export 'cat_gateway_api.swagger.dart' show CatGatewayApi; | |||
export 'vit.swagger.dart' show Vit; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does happen with the cat_gateway_api? We will need it as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, forgot about it.
@@ -0,0 +1,100 @@ | |||
import 'package:catalyst_voices_services/generated/catalyst_gateway/vit.models.swagger.dart'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if vitss was not under catalyst)gateway
because its not part of catalyst gateway.
Just so the distinction is clearer.
Perhaps in package:catalyst_voices_services/generated/vitss/*
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, wanted to do it too but swagger_dart_code_generator allows only one input_folder
/output_folder
folder.
I was thinking about renaming catalyst_gateway
to api
because later generated classes have descriptive names anyways.
so from
├── generated
│ └── catalyst_gateway
│ ├── cat_gateway_api.enums.swagger.dart
│ ├── cat_gateway_api.models.swagger.dart
│ ├── cat_gateway_api.models.swagger.g.dart
│ ├── cat_gateway_api.swagger.chopper.dart
│ ├── cat_gateway_api.swagger.dart
│ ├── client_index.dart
│ ├── client_mapping.dart
│ ├── vit.enums.swagger.dart
│ ├── vit.models.swagger.dart
│ ├── vit.models.swagger.g.dart
│ ├── vit.swagger.chopper.dart
│ └── vit.swagger.dart
to
├── generated
│ └── api
│ ├── cat_gateway_api.enums.swagger.dart
│ ├── cat_gateway_api.models.swagger.dart
│ ├── cat_gateway_api.models.swagger.g.dart
│ ├── cat_gateway_api.swagger.chopper.dart
│ ├── cat_gateway_api.swagger.dart
│ ├── client_index.dart
│ ├── client_mapping.dart
│ ├── vit.enums.swagger.dart
│ ├── vit.models.swagger.dart
│ ├── vit.models.swagger.g.dart
│ ├── vit.swagger.chopper.dart
│ └── vit.swagger.dart
does it make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe even rename cat_gateway_api
to just cat_gateway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a required change, but a suggestion for clarity.
Description
openapi
dir.Not sure if vit.yaml is somewhat ill formatted or code generation is not working properly but it was not able to generate correct classes for SimpleProposal and CommunityChoiceProposal, that's why i added overriden_models.dart where i implemented them by hand as it was fastest solution (we'll remove it anyways later).
Moreover types in some endpoints are not defined at all. For example
GET fund
looks like thiswhere openapi says
other endpoints are mostly fine but we'll have to keep eye on it.
cc @minikin
Related Issue(s)
Resolves #1298
Please confirm the following checks